Руслан Ижбулатов [Wed, 26 Mar 2014 06:54:52 +0000 (06:54 +0000)]
W32: Make combobox-entry thinner by removing unneeded padding
https://bugzilla.gnome.org/show_bug.cgi?id=727075
Руслан Ижбулатов [Tue, 25 Mar 2014 17:47:08 +0000 (17:47 +0000)]
W32: Fix menu item size and submenu arrow size
https://bugzilla.gnome.org/show_bug.cgi?id=727037
Руслан Ижбулатов [Tue, 25 Mar 2014 17:35:02 +0000 (17:35 +0000)]
W32: Fix combobox dropdown list color
https://bugzilla.gnome.org/show_bug.cgi?id=727036
Руслан Ижбулатов [Tue, 25 Mar 2014 17:25:47 +0000 (17:25 +0000)]
W32: Fix double-arrowed combobox button
The arrow is part of the background image drawn by the theme, don't draw
GTK's own arrow. This also applies to non-entry comboboxes.
On XP the arrow-and-nothing-else part does not exist (W32 XP theme draws a
white rectangle) and has to be subtituted for a simple dropdown button even
for non-entry comboboxes.
https://bugzilla.gnome.org/show_bug.cgi?id=727035
Руслан Ижбулатов [Tue, 25 Mar 2014 15:47:56 +0000 (15:47 +0000)]
Fix W32 theme for spinbuttons
It seems that the dec-button no longer has a "bottom" selector-thingy to
select for. Use "last-child" instead.
Use .vertical to style vertical instance differently, as last-child/first-child
meaning is inverted there.
Increase (towards 0) margins a bit, to avoid clipping the pre-light rectangle.
Use dir(rtl) selector to style horizontal instance differently for RTL locales,
where first-child is "inc".
https://bugzilla.gnome.org/show_bug.cgi?id=727022
Paolo Borelli [Sun, 30 Mar 2014 16:29:15 +0000 (18:29 +0200)]
textbufferserialize: do not leak list of tags
Paolo Borelli [Sun, 30 Mar 2014 09:57:23 +0000 (11:57 +0200)]
application-dbus: free strings during finalization
Paolo Borelli [Sat, 29 Mar 2014 22:14:51 +0000 (23:14 +0100)]
stackswitcher: do not leak buttons hash table
Matthias Clasen [Sat, 29 Mar 2014 04:46:51 +0000 (00:46 -0400)]
flow box: Avoid excessive signals
We were emitting the a11y ::selection-changed signal much more
often than ::selected-children-changed. Thats not necessary.
Matthias Clasen [Sat, 29 Mar 2014 04:24:15 +0000 (00:24 -0400)]
docs: Another round of markup removal
Matthias Clasen [Fri, 28 Mar 2014 23:19:37 +0000 (19:19 -0400)]
Trivial typo fix
Matthias Clasen [Fri, 28 Mar 2014 22:21:59 +0000 (18:21 -0400)]
Docs: remove some leftover markup
Jonas Danielsson [Fri, 28 Mar 2014 12:43:33 +0000 (13:43 +0100)]
clipboard: Add link to GdkDisplay in doc
https://bugzilla.gnome.org/show_bug.cgi?id=712752
Chun-wei Fan [Fri, 14 Mar 2014 08:33:53 +0000 (16:33 +0800)]
gdkproperty-win32.c: Fix gtk-font-name handling
...on Windows 8+ and when the system setting for non-Unicode programs do
not match the language version of Windows by falling back to using Pango.
This ensures that the correct font is used during these scenarios, so that
we minimize the risk of seeing garbled characters for texts that the system
code page does not support due to system peculiarties. There might be a
way to support gtk-font-name handling using the native Windows APIs
directly on Windows 8+, but that needs to be investigated.
https://bugzilla.gnome.org/show_bug.cgi?id=726298
Bastien Nocera [Sat, 22 Mar 2014 11:47:55 +0000 (12:47 +0100)]
treeview: Lower the duration of validation iterations
GTK_TREE_VIEW_TIME_MS_PER_IDLE is currently 30 milliseconds, meaning
that validate_rows will validate rows up until all the validations have
taken over 30 msecs. So it's likely to block redrawing via the clock
frame update mechanism, as that tops at 16.66 milliseconds per frame
(1/60th of a second).
Stop validating rows if we've spent more than 3/5 of our allotted budget
for inter-frame processing, so as to avoid blocking.
In the future, we would probably want to calculate how long we would
have left until the next frame, especially if higher priority idles
and timeouts have already consumed a portion of that allotted time.
https://bugzilla.gnome.org/show_bug.cgi?id=726871
Olivier Brunel [Thu, 16 Jan 2014 14:23:20 +0000 (15:23 +0100)]
treemodelfilter: Fix using wrong path on row-deleted
A "typo" led to using a wrong GtkTreePath when converting the path of the
virtual root to check the ancestors, which would lead to either no checks being
performed, or maybe segfaulting when using an invalid path as result.
https://bugzilla.gnome.org/show_bug.cgi?id=722058
Signed-off-by: Olivier Brunel <jjk@jjacky.com>
John Lindgren [Sat, 22 Mar 2014 03:12:04 +0000 (23:12 -0400)]
Allow gtk_radio_menu_item_set_group() to be called twice without crashing.
https://bugzilla.gnome.org/show_bug.cgi?id=726859
Bastien Nocera [Sat, 22 Mar 2014 11:44:01 +0000 (12:44 +0100)]
all: Name more idles and timeouts
Following up from
438cd857c49242244dda2923ac447f36464b9e72,
name more timeouts and idles.
The original grep was missing checking for gdk_threads_add_*()
functions (at least for some of the files).
https://bugzilla.gnome.org/show_bug.cgi?id=726870
Matthias Clasen [Thu, 27 Mar 2014 00:00:58 +0000 (20:00 -0400)]
widget-factory: Use a popover gear menu
Inaki Larranaga Murgoitio [Wed, 26 Mar 2014 13:52:54 +0000 (14:52 +0100)]
Updated Basque language
Inaki Larranaga Murgoitio [Wed, 26 Mar 2014 13:39:31 +0000 (14:39 +0100)]
Updated Basque language
Stas Solovey [Wed, 26 Mar 2014 13:39:19 +0000 (13:39 +0000)]
Updated Russian translation
Yuri Myasoedov [Wed, 26 Mar 2014 08:12:25 +0000 (12:12 +0400)]
Some fixes for Russian translation
Yuri Myasoedov [Wed, 26 Mar 2014 07:43:08 +0000 (11:43 +0400)]
Some fixes for Russian translation
Yuri Myasoedov [Wed, 26 Mar 2014 07:27:40 +0000 (11:27 +0400)]
Some fixes and updates for Russian translation
Joanmarie Diggs [Mon, 24 Mar 2014 22:19:40 +0000 (18:19 -0400)]
Add missing AtkRelations for labelled containers in the print dialog
These AtkRelation types are added automatically for widgets with a label
specified (e.g. via gtk_label_set_mnemonic_widget, gtk_frame_set_label,
and gtk_frame_set_label_widget). When such specification is absent, the
accessible relationship must be manually set.
https://bugzilla.gnome.org/show_bug.cgi?id=726996
Antoine Jacoutot [Tue, 25 Mar 2014 11:24:41 +0000 (12:24 +0100)]
prevent redefinition of typedef GtkPrinterCloudprint
https://bugzilla.gnome.org/show_bug.cgi?id=727009
Matthias Clasen [Tue, 25 Mar 2014 01:07:09 +0000 (21:07 -0400)]
Bump version
Matthias Clasen [Mon, 24 Mar 2014 16:55:41 +0000 (12:55 -0400)]
3.12.0
Cosimo Cecchi [Tue, 25 Mar 2014 00:14:43 +0000 (20:14 -0400)]
icontheme: fix emblemed icons fallout
Commit
faba7df4fea6cd09470b3b2cc277c35e6cf7c380 changed the logic in
apply_emblems() so that GtkIconInfo->emblems_applied would be set to
TRUE even in case there was no emblem info available, which confuses the
theme cache.
This commit changes the logic back, so that NULL is returned from
apply_emblems_to_pixbuf() when there are no emblems available, fixing
the bug.
https://bugzilla.gnome.org/show_bug.cgi?id=726830
Matthias Clasen [Tue, 25 Mar 2014 00:10:02 +0000 (20:10 -0400)]
Add a testcase for icons with emblems
This is a testcase for
https://bugzilla.gnome.org/show_bug.cgi?id=726830
Matthias Clasen [Mon, 24 Mar 2014 18:28:03 +0000 (14:28 -0400)]
Minor update of a11y test output
Matthias Clasen [Mon, 24 Mar 2014 17:36:13 +0000 (13:36 -0400)]
Update release notes
Johannes Wellhöfer [Sun, 13 Oct 2013 14:15:18 +0000 (16:15 +0200)]
Also revert enable-mnemonics code in gtkwindow, which was forgotten in commit
34cf40e95cb1f0bc4bb98bb14edb03dd86f1dab3.
https://bugzilla.gnome.org/show_bug.cgi?id=708346
Christian Kirbach [Mon, 24 Mar 2014 22:20:06 +0000 (22:20 +0000)]
Updated German translation
Matthias Clasen [Mon, 24 Mar 2014 16:49:32 +0000 (12:49 -0400)]
wayland: Mark ourselves as not supporting compositing
The compositing that is meant here is really specific to the
X11 Composite extension, and does not apply to Wayland.
This is very rarely used functionality anyway, and none of
the other backends support it.
Kai Willadsen [Sat, 22 Mar 2014 22:12:09 +0000 (08:12 +1000)]
docs: Document gtk_recent_filter_filter() requirements
gtk_recent_filter_filter() needs the contains bitfield to be set, but
this only mentions that the other fields are required.
https://bugzilla.gnome.org/show_bug.cgi?id=726900
Marek Kasik [Tue, 18 Mar 2014 11:43:46 +0000 (12:43 +0100)]
printing: Draw print dialog on fullscreen windows
Set correct "type-hint" for GtkPrintUnixDialog ("dialog").
Otherwise the print dialog is not shown when its parent
window is in fullscreen mode.
https://bugzilla.gnome.org/show_bug.cgi?id=724728
Benjamin Otte [Mon, 24 Mar 2014 15:34:08 +0000 (16:34 +0100)]
a11y: Move relationset updating to new vfunc
This way, we don't create lots of cell accessibles when creating the
first one (because surely one is the parent/child of another who again
is a parent/child of another who again....)
Benjamin Otte [Mon, 24 Mar 2014 14:51:38 +0000 (15:51 +0100)]
a11y: Add API to update relationsets of cells to their parents
Benjamin Otte [Mon, 24 Mar 2014 15:32:59 +0000 (16:32 +0100)]
a11y: Don't unref relations
Nobody was reffing those related object in the first place and that
was causing random crashes.
And if somebody had reffed those related objects, they'd have caused
reference cycles.
https://bugzilla.gnome.org/show_bug.cgi?id=726838
Matthias Clasen [Fri, 21 Mar 2014 19:41:13 +0000 (15:41 -0400)]
Don't let themes override explicit border-width in dialogs
This fixes an issue where the theme-provided border-width prevents
dialog contents from lining up properly with the headerbar. To make
this work in message dialogs, we have to explicitly set the border-
width of the action area to 0.
Matthias Clasen [Mon, 24 Mar 2014 12:35:27 +0000 (08:35 -0400)]
Revert "Don't let themes override explicit border-width in dialogs"
This reverts commit
6e4567e73bceb66200b9605c51b4b5ad6e807483.
For some reason, this causes buttons in message dialogs to have an
unwanted border.
Matthias Clasen [Mon, 24 Mar 2014 11:00:42 +0000 (07:00 -0400)]
gtk-demo: Fix underlines
The iconview example was showing literal underlines. We don't want
that.
Petr Kovar [Sun, 23 Mar 2014 16:09:24 +0000 (17:09 +0100)]
Update Czech po-properties translation
Petr Kovar [Sun, 23 Mar 2014 15:38:29 +0000 (16:38 +0100)]
Update Czech translation
Мирослав Николић [Sun, 23 Mar 2014 13:24:07 +0000 (14:24 +0100)]
Updated Serbian translation
Мирослав Николић [Sun, 23 Mar 2014 10:53:12 +0000 (11:53 +0100)]
Updated Serbian translation
Milo Casagrande [Sat, 22 Mar 2014 13:48:41 +0000 (13:48 +0000)]
Updated Italian translation
Milo Casagrande [Sat, 22 Mar 2014 13:47:59 +0000 (13:47 +0000)]
Updated Italian translation
Daniel Korostil [Sat, 22 Mar 2014 10:22:46 +0000 (12:22 +0200)]
Updated Ukrainian translation
John Lindgren [Sat, 22 Mar 2014 02:34:13 +0000 (22:34 -0400)]
Fix typo (GTK_ENABLE_DEBUG vs. G_ENABLE_DEBUG).
https://bugzilla.gnome.org/show_bug.cgi?id=726858
Matthias Clasen [Sat, 22 Mar 2014 02:37:36 +0000 (22:37 -0400)]
font chooser: Update font list on font changes
We do get a style-updated emission when new fonts are installed.
Update the font list in this case.
https://bugzilla.gnome.org/show_bug.cgi?id=726476
Matthias Clasen [Sat, 22 Mar 2014 02:06:24 +0000 (22:06 -0400)]
file chooser: Don't react to entry changes in select-folder mode
In select-folder mode, we are putting the directory name into the
entry ourselves. Then the entry appends a /. If we react to this
'spontaneous' change of the entry by clearing the list selection,
this will in turn make us clear the entry. We don't want that.
https://bugzilla.gnome.org/show_bug.cgi?id=726855
Gábor Kelemen [Sat, 22 Mar 2014 00:50:40 +0000 (00:50 +0000)]
Updated Hungarian translation
Matthias Clasen [Fri, 21 Mar 2014 22:22:46 +0000 (18:22 -0400)]
wayland: Fix northeast resizing
Surprisingly, the same corner that was broken for resizing under
X is also broken under Wayland, for an entirely different reason.
Pierre-Eric Pelloux-Prayer [Wed, 12 Mar 2014 16:02:58 +0000 (17:02 +0100)]
broadway: make sure color/delta run length do not overflow
Fixes bug 723045.
Matthias Clasen [Fri, 21 Mar 2014 19:41:13 +0000 (15:41 -0400)]
Don't let themes override explicit border-width in dialogs
This fixes an issue where the theme-provided border-width prevents
dialog contents from lining up properly with the headerbar.
Matthias Clasen [Fri, 21 Mar 2014 19:39:46 +0000 (15:39 -0400)]
Fix undecorated windows
Setting windows undecorated was broken by some of the recent
shadow width changes. We need to ensure that shadow width is
zero for undecorated windows, then things work again.
Carlos Garnacho [Fri, 21 Mar 2014 14:31:40 +0000 (15:31 +0100)]
window: Unset source ID before possibly destroying the widget
If the delete event ends up destroying the widget, unsetting
priv->delete_event_handler will happen on invalid memory, so
unset it before the widget is possibly destroyed.
https://bugzilla.gnome.org/show_bug.cgi?id=726825
Carlos Garnacho [Fri, 21 Mar 2014 14:28:36 +0000 (15:28 +0100)]
a11y: Remove weak reference when updating a GtkPopoverAccessible relative-to widget
Otherwise the weak reference is left dangling, which later causes issues at the time
of destroying that widget.
https://bugzilla.gnome.org/show_bug.cgi?id=726749
Andika Triwidada [Fri, 21 Mar 2014 10:13:02 +0000 (10:13 +0000)]
Updated Indonesian translation
Andika Triwidada [Fri, 21 Mar 2014 07:20:38 +0000 (07:20 +0000)]
Updated Indonesian translation
Jasper St. Pierre [Tue, 18 Mar 2014 13:38:06 +0000 (09:38 -0400)]
wayland: Mark ourselves as not supporting bounding shapes
Theoretically, we apply the shape mask client-side ourselves
with an ARGB32 pixmap and intersect it to get a union shape,
but I don't particularly care enough to write that code.
Realistic application code using bounding shapes in 2014 is
quite rare.
Jasper St. Pierre [Mon, 17 Mar 2014 20:02:47 +0000 (16:02 -0400)]
wayland: Add support for input regions
Jasper St. Pierre [Mon, 17 Mar 2014 20:08:35 +0000 (16:08 -0400)]
wayland: Refactor how opaque region is handled
Move to a sync system just like the rest of the properties.
Benjamin Otte [Thu, 20 Mar 2014 13:34:31 +0000 (14:34 +0100)]
docs: Add more information to gtk_widget_set_realized()
It's important to point out that widgets should only be marked as
realized very late in the process. Even GTK widgets don't get this
right.
https://bugzilla.gnome.org/show_bug.cgi?id=726717
Benjamin Otte [Thu, 20 Mar 2014 13:11:02 +0000 (14:11 +0100)]
expander: Call set_realized() later
Widgets should only call set_realized() after having created and
registered their GDK windows. In this case, the creation of the style
context (or more exactly: figuring out the scale factor for it) requires
knowing if the widget is already realized. Which it isn't.
https://bugzilla.gnome.org/show_bug.cgi?id=726717
GunChleoc [Thu, 20 Mar 2014 08:46:04 +0000 (08:46 +0000)]
Updated Scottish Gaelic translation
GunChleoc [Thu, 20 Mar 2014 08:27:29 +0000 (08:27 +0000)]
Updated Scottish Gaelic translation
GunChleoc [Thu, 20 Mar 2014 08:24:23 +0000 (08:24 +0000)]
Updated Scottish Gaelic translation
GunChleoc [Thu, 20 Mar 2014 08:20:58 +0000 (08:20 +0000)]
Updated Scottish Gaelic translation
Ask H. Larsen [Wed, 19 Mar 2014 20:52:16 +0000 (21:52 +0100)]
Updated Danish translation
Ask H. Larsen [Wed, 19 Mar 2014 20:50:35 +0000 (21:50 +0100)]
Updated Danish translation
Gábor Kelemen [Wed, 19 Mar 2014 15:57:33 +0000 (15:57 +0000)]
Updated Hungarian translation
Benjamin Otte [Wed, 19 Mar 2014 12:23:38 +0000 (13:23 +0100)]
container: guard container variable by reffing it
vte destroys the container during removal of a child. Don't crash in
that case due to recent a11y refactoring.
https://bugzilla.gnome.org/show_bug.cgi?id=726369
Benjamin Otte [Mon, 17 Mar 2014 01:09:31 +0000 (02:09 +0100)]
cssprovider: Fix error message
expected a valid semicolon
sounds kinda not so great. Make it say
expected semicolon
Unless somebody can tell me the difference between valid and invalid
semicolons?
Matthias Clasen [Tue, 18 Mar 2014 23:50:59 +0000 (19:50 -0400)]
Ensure proper spacing around icons in message dialogs
We had a margin of 30 before/after the text. Put that add around
the icon as well, and separate the icon and text by 30 pixels.
This does not affect the appearance of message dialogs without
icons.
Matthias Clasen [Tue, 18 Mar 2014 23:49:10 +0000 (19:49 -0400)]
Add at testcase for a message dialog with icon
Icons in message dialogs may be deprecated, but we still need
to place them properly, so add a testcase.
Murray Cumming [Tue, 18 Mar 2014 11:29:49 +0000 (12:29 +0100)]
docs: Tiny GtkApplication typo fixes.
Matthias Clasen [Tue, 18 Mar 2014 02:46:22 +0000 (22:46 -0400)]
GtkDialog: Add some padding to title label
Matthias Clasen [Tue, 18 Mar 2014 00:21:28 +0000 (20:21 -0400)]
Bump version
Matthias Clasen [Mon, 17 Mar 2014 23:13:53 +0000 (19:13 -0400)]
GtkPopover: Fix two doc comments
Matthias Clasen [Mon, 17 Mar 2014 22:18:53 +0000 (18:18 -0400)]
x11: Allow unmaximizing from tiled state too
This lets us unmaximize a half-tiled csd window on a touch system.
Matthias Clasen [Mon, 17 Mar 2014 22:14:53 +0000 (18:14 -0400)]
Update a11y test output
Jasper St. Pierre [Mon, 17 Mar 2014 19:42:43 +0000 (15:42 -0400)]
wayland: Remove cruft in set_keep_above / set_keep_below
It's been decided: these will most likely never be supported on
Wayland, so remove the "stub" implementation of them.
Jasper St. Pierre [Mon, 17 Mar 2014 19:41:08 +0000 (15:41 -0400)]
wayland: Fix get_frame_extents
We need to traverse up the hierarchy for windows here. Just use
our existing helper method for this.
Jasper St. Pierre [Mon, 17 Mar 2014 19:39:39 +0000 (15:39 -0400)]
Implement get_root_origin generically for all backends
It seems that some backends implemented get_root_origin wrong
and returned the client window coordinates, not the frame window
coordinates. Since it's possible to implement generically for all
windows, let's do that instead of having a separate impl vfunc.
Matthias Clasen [Mon, 17 Mar 2014 19:45:21 +0000 (15:45 -0400)]
Updates
Jasper St. Pierre [Mon, 17 Mar 2014 19:27:13 +0000 (15:27 -0400)]
wayland: Fix "fake root" coords
We were incorrectly summing up our own window over and over
rather than the coordinates of the parent windows.
Jasper St. Pierre [Mon, 17 Mar 2014 19:25:23 +0000 (15:25 -0400)]
wayland: Add a giant doc comment explaining "fake root" coordinate space
Jasper St. Pierre [Mon, 17 Mar 2014 19:11:13 +0000 (15:11 -0400)]
wayland: Properly apply the fake root offset to event coordinates
GdkEvent's x_root and y_root values should be in the same "fake root
window" coordinate space as gdk_window_get_root_coords.
Jasper St. Pierre [Mon, 17 Mar 2014 18:58:37 +0000 (14:58 -0400)]
wayland: Fill in x_root / y_root of events properly
Lots of code, including dragging code in GtkWindow, use these
fields. Setting them to 0 causes lots of strange and weird bugs.
Use the same "hack" from query_device_state of just using
win_x / win_y for now. We'll convert this to the proper fake root
coordinate system used by get_root_coords in the next commit.
Matthias Clasen [Mon, 17 Mar 2014 19:00:45 +0000 (15:00 -0400)]
Update documentation about link styling
The ::link-color and ::visited-link-color style properties
are ignored now. Document that.
Marek Kasik [Fri, 14 Mar 2014 14:36:10 +0000 (15:36 +0100)]
printing: Fail nicely when /tmp is not writable
Don't crash when /tmp is not writable when printing to file.
Show that getting of printer details failed for CUPS printers.
https://bugzilla.gnome.org/show_bug.cgi?id=693200
Carlos Garnacho [Mon, 17 Mar 2014 16:42:07 +0000 (17:42 +0100)]
textview: Mind the lateral windows when setting handles/popovers positions
If a textview had lateral windows that might displace the text window, the
handles and popovers would appear displaced. Those lateral windows aren't
affected by RTL/LTR settings, so just checking for left/top is ok here.
Carlos Garnacho [Thu, 13 Mar 2014 20:12:55 +0000 (21:12 +0100)]
x11: Implement "drag to top to maximize" gesture on emulated window dragging
And the counterpart to unmaximize when dragging a maximized window, if
touch devices aren't going to use EWMH moveresize, having this one at least
makes things feel a bit less awkward.
https://bugzilla.gnome.org/show_bug.cgi?id=709914
Carlos Garnacho [Thu, 13 Mar 2014 19:19:26 +0000 (20:19 +0100)]
x11: Fallback to emulated window dragging for touch devices
Sadly, EWMH moveresize mechanism can't work with touch devices for two
reasons:
1) As a mutter implementation detail, the device is queried in order
to check whether the dragging button is still pressed. Touch devices
won't report the button 1 being pressed through pointer emulation.
2) Even bypassing that check, on X11 touch events are selected prior
to sequences being started, either through XISelectEvents or
XIGrabTouchBegin, no late registering through active grabs is allowed,
as WMs do on reaction to EWMH moveresize messages.
So for the time being, make touch devices fallback on emulated window
dragging, which at least allows for moving windows.
https://bugzilla.gnome.org/show_bug.cgi?id=709914
Bastien Nocera [Mon, 17 Mar 2014 08:27:36 +0000 (09:27 +0100)]
dialog: Avoid possible use-after-free
When the dialogue's titlebar was replaced, we were still trying to
update the label we constructed but that was now destroyed.
https://bugzilla.gnome.org/show_bug.cgi?id=726492
Ville-Pekka Vainio [Sun, 16 Mar 2014 19:46:47 +0000 (21:46 +0200)]
Finnish translation update by Jiri Grönroos